Feat(revit): CNX-543 category filter #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #373 +/- ##
=====================================
Coverage 8.39% 8.40%
=====================================
Files 238 237 -1
Lines 4692 4690 -2
Branches 512 512
=====================================
Hits 394 394
+ Misses 4282 4280 -2
Partials 16 16 ☔ View full report in Codecov by Sentry. |
JR-Morgan
requested changes
Nov 8, 2024
| @@ -17,6 +18,9 @@ public async Task RefreshSendFilters() => | |||
| public async Task SetModelsExpired(IEnumerable<string> expiredModelIds) => | |||
| await Bridge.Send(SET_MODELS_EXPIRED_UI_COMMAND_NAME, expiredModelIds).ConfigureAwait(false); | |||
|
|
|||
| public async Task SetFilterObjectIds<T>(string modelCardId, T idMap) => | |||
There was a problem hiding this comment.
T generic arg could be replaced with object
| public override List<string> GetObjectIds() => SelectedObjectIds; | ||
| public override List<string> RefreshObjectIds() | ||
| { | ||
| ObjectIds = SelectedObjectIds; // We know it is bad, it is for backward compatibility! |
There was a problem hiding this comment.
Can we use SelectedObjectIds everywhere instead? add on the ISendFilter.
I don't think the name will be confusing,
JR-Morgan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.