Dogukan/cnx 790 version independent plugin icon #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dogukankaratas
commented
Nov 15, 2024
dogukankaratas
commented
- adds version agnostic icon reading
- updates grid converter because v2023 decimal is "," and v2024 decimal is "."
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #386 +/- ##
=====================================
Coverage 8.38% 8.38%
=====================================
Files 237 237
Lines 4701 4701
Branches 513 513
=====================================
Hits 394 394
Misses 4291 4291
Partials 16 16 ☔ View full report in Codecov by Sentry. |
oguzhankoral
approved these changes
Nov 15, 2024
oguzhankoral
deleted the
dogukan/cnx-790-version-independent-plugin-icon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.