-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNX-755: Create Collections by Category #387
CNX-755: Create Collections by Category #387
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #387 +/- ##
=====================================
Coverage 8.37% 8.37%
=====================================
Files 237 237
Lines 4704 4704
Branches 513 513
=====================================
Hits 394 394
Misses 4294 4294
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing you in v3 PRs, nice 🫠 Lets sync tmr
Connectors/Tekla/Speckle.Connector.TeklaShared/HostApp/SendCollectionManager.cs
Show resolved
Hide resolved
Connectors/Tekla/Speckle.Connector.TeklaShared/HostApp/SendCollectionManager.cs
Outdated
Show resolved
Hide resolved
Welcome to the DUI3 💯. During testing I noticed that renderMaterial proxies are not attached to the objects properly and there are objects with no color. That's due to TeklaMaterialUnpacker relies on the application IDs of objects to associate them with the objects. When the subcollections are created, the proxies cannot find the corresponding IDs. A new logic is needed in TeklaMaterialUnpacker to check the collection path. |
@dogukankaratas This is expected. We are not attaching any render material info into any object. New collections shouldn't effect it. Seems like something else. I can help tomorrow to debug. |
Removing iteration where path (currently) only contains 1 item
Description & motivation
Changes:
teklaObject
bytype
.SendCollectionManager.cs
added as done with Revit.Screenshots:
Before
After
Validation of changes:
Basic Steel Model
Exceptions
minimalChecklist: