Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNX-755: Create Collections by Category #387

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

bjoernsteinhagen
Copy link
Contributor

Description & motivation

Changes:

  • Grouping of teklaObject by type.
  • SendCollectionManager.cs added as done with Revit.

Screenshots:

Before

image

After

image

Validation of changes:

  • Tested on the Basic Steel Model
  • Since grouping is very high-level (not drilling down into property names etc.), chances of Exceptions minimal

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

Copy link

linear bot commented Nov 17, 2024

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.37%. Comparing base (c8ac385) to head (e728226).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #387   +/-   ##
=====================================
  Coverage   8.37%   8.37%           
=====================================
  Files        237     237           
  Lines       4704    4704           
  Branches     513     513           
=====================================
  Hits         394     394           
  Misses      4294    4294           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing you in v3 PRs, nice 🫠 Lets sync tmr

@dogukankaratas
Copy link
Contributor

Welcome to the DUI3 💯.

During testing I noticed that renderMaterial proxies are not attached to the objects properly and there are objects with no color.

image

That's due to TeklaMaterialUnpacker relies on the application IDs of objects to associate them with the objects. When the subcollections are created, the proxies cannot find the corresponding IDs.

A new logic is needed in TeklaMaterialUnpacker to check the collection path.

@oguzhankoral
Copy link
Member

Welcome to the DUI3 💯.

During testing I noticed that renderMaterial proxies are not attached to the objects properly and there are objects with no color.

image

That's due to TeklaMaterialUnpacker relies on the application IDs of objects to associate them with the objects. When the subcollections are created, the proxies cannot find the corresponding IDs.

A new logic is needed in TeklaMaterialUnpacker to check the collection path.

@dogukankaratas This is expected. We are not attaching any render material info into any object. New collections shouldn't effect it. Seems like something else. I can help tomorrow to debug.

Removing iteration where path (currently) only contains 1 item
@bjoernsteinhagen bjoernsteinhagen merged commit 4215f90 into dev Nov 18, 2024
5 checks passed
@bjoernsteinhagen bjoernsteinhagen deleted the bjorn/cnx-755-create-collections-by-category branch November 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants