Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogukan/cnx-739-object-tracking-in-tekla #398

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

dogukankaratas
Copy link
Contributor

Description & motivation

  • Adds the functionality to notify user if there is any change in the objects already sent to Speckle.
  • Does not trigger the idle for now, will figure out that in the future.
  • Works together with the cache to not to convert already converted objects.

Changes:

  • Events.OnModelObjectChange class listens the Tekla instance and catch modified object ID's.

image

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

Copy link

linear bot commented Nov 20, 2024

@dogukankaratas dogukankaratas changed the title adds object tracking dogukan/cnx-739-object-tracking-in-tekla Nov 20, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.37%. Comparing base (85abeaf) to head (941c334).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #398   +/-   ##
=====================================
  Coverage   8.37%   8.37%           
=====================================
  Files        237     237           
  Lines       4704    4704           
  Branches     514     514           
=====================================
  Hits         394     394           
  Misses      4294    4294           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dogukankaratas could you create follow up ticket for idling issue? Or would be nice if you can investigate how bad the current status without idling. For example test to change maaaany elements at once, move all etc

@oguzhankoral oguzhankoral merged commit 1e5cca5 into dev Nov 21, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the dogukan/cnx-739-object-tracking-in-tekla branch November 21, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants