Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(revit): aligns revit send for data extraction workflow #399

Merged

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented Nov 20, 2024

  • removes direct conversions of a lot of built elements classes and instead sends most revit elements as RevitObject
  • cleans up properties on some revit elements, mostly display meshes and hosted elements logic
  • adds profile property to a lot of classes in the classpropertyextractor. This replaces the outline and voids/openings prop of the builtelelements classes, and resolves old bugs on identifying outline curve vs void curves.
  • adds location property by defualt to all objects that have it. previously these were sent as baseCurve, baseLine, or position/point props on structural and instance elements.
  • fixes railing bug
  • fixes empty stacked wall display value bug
  • note: Levels are still attached on every object as a Level object. should refactor this to use level proxies instead in another pr.

Before:
https://app.speckle.systems/projects/b53a53697a/models/00daea8ea0@3bb4c0ac17
{7E025E89-3A0F-4766-ADC0-F86E79D8830A}

After:
https://app.speckle.systems/projects/b53a53697a/models/00daea8ea0@0a119be678
{79A17A5E-70F1-445A-AA02-43A2B7234D50}

Copy link

linear bot commented Nov 20, 2024

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 225 lines in your changes missing coverage. Please review.

Project coverage is 9.18%. Comparing base (92acb31) to head (07d7e5a).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...d/ToSpeckle/Properties/ClassPropertiesExtractor.cs 0.00% 93 Missing ⚠️
...TopLevel/RevitElementTopLevelConverterToSpeckle.cs 0.00% 85 Missing ⚠️
...vitShared/ToSpeckle/Raw/LevelToSpeckleConverter.cs 0.00% 17 Missing ⚠️
...tShared/ToSpeckle/Properties/ParameterExtractor.cs 0.00% 13 Missing ⚠️
...e.Connectors.Common/Operations/RootObjectSender.cs 0.00% 6 Missing ⚠️
...e/TopLevel/ModelCurveToSpeckleTopLevelConverter.cs 0.00% 4 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 2 Missing ⚠️
...e/TopLevel/PointcloudTopLevelConverterToSpeckle.cs 0.00% 2 Missing ⚠️
...ckle.Converters.RevitShared/ServiceRegistration.cs 0.00% 1 Missing ⚠️
...Shared/ToSpeckle/Raw/LocationToSpeckleConverter.cs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #399      +/-   ##
========================================
+ Coverage   8.30%   9.18%   +0.88%     
========================================
  Files        239     223      -16     
  Lines       4743    4288     -455     
  Branches     512     472      -40     
========================================
  Hits         394     394              
+ Misses      4333    3878     -455     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clairekuang and others added 3 commits November 21, 2024 11:11
* feat: makes levels dicts and memoizes converter

* feat: makes top level props also not detached

* feat: unifies `level` extraction in top level

* fix: linting
Copy link
Member

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smells fine

@clairekuang clairekuang enabled auto-merge (squash) November 26, 2024 13:50
@clairekuang clairekuang merged commit c5e14e7 into dev Nov 26, 2024
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-793-revit-cleanup-align-with-data-extraction-workflow branch November 26, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants