-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(revit): aligns revit send for data extraction workflow #399
Merged
clairekuang
merged 21 commits into
dev
from
claire/cnx-793-revit-cleanup-align-with-data-extraction-workflow
Nov 26, 2024
Merged
refactor(revit): aligns revit send for data extraction workflow #399
clairekuang
merged 21 commits into
dev
from
claire/cnx-793-revit-cleanup-align-with-data-extraction-workflow
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd class property extractor
…extraction-workflow
…extraction-workflow
…extraction-workflow
…extraction-workflow
* feat: makes levels dicts and memoizes converter * feat: makes top level props also not detached * feat: unifies `level` extraction in top level * fix: linting
adamhathcock
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smells fine
…extraction-workflow
…extraction-workflow
…extraction-workflow
adamhathcock
approved these changes
Nov 26, 2024
clairekuang
deleted the
claire/cnx-793-revit-cleanup-align-with-data-extraction-workflow
branch
November 26, 2024 13:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RevitObject
profile
property to a lot of classes in theclasspropertyextractor
. This replaces theoutline
andvoids/openings
prop of the builtelelements classes, and resolves old bugs on identifying outline curve vs void curves.location
property by defualt to all objects that have it. previously these were sent asbaseCurve
,baseLine
, orposition/point
props on structural and instance elements.Levels
are still attached on every object as aLevel
object. should refactor this to use level proxies instead in another pr.Before:
https://app.speckle.systems/projects/b53a53697a/models/00daea8ea0@3bb4c0ac17
After:
https://app.speckle.systems/projects/b53a53697a/models/00daea8ea0@0a119be678