Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (tekla): greyscaled objects in the viewer #412

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

dogukankaratas
Copy link
Contributor

@dogukankaratas dogukankaratas commented Nov 26, 2024

description

removes the logic of attaching applicationid to displayvalue. we're solving this on receive side.

checklist

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

Copy link

linear bot commented Nov 26, 2024

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.30%. Comparing base (9d6c7de) to head (0ecd77c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #412   +/-   ##
=====================================
  Coverage   9.30%   9.30%           
=====================================
  Files        224     224           
  Lines       4234    4234           
  Branches     471     471           
=====================================
  Hits         394     394           
  Misses      3824    3824           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjoernsteinhagen
Copy link
Contributor

Nice @dogukankaratas. Viewer looking good for me:

image

Rhino receive is, I believe, a separate issue (?)

image

@dogukankaratas
Copy link
Contributor Author

@bjoernsteinhagen can you try receiving in Revit? the issue in Rhino solved here: #408

@bjoernsteinhagen
Copy link
Contributor

@dogukankaratas sorry, I forgot you mentioning that! Revit works :)

@oguzhankoral oguzhankoral enabled auto-merge (squash) November 27, 2024 14:45
@oguzhankoral oguzhankoral merged commit 3ad4d46 into dev Nov 27, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the dogukan/cnx-818-greyscaled-objects-in-the-viewer branch November 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants