Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navisworks): Update Navisworks connector plugin bundle target and version content target paths. #464

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

jsdbroughton
Copy link
Contributor

  • Update the plugin bundle target path to "$(AppData)\Autodesk\ApplicationPlugins\Speckle.Connectors.Navisworks.bundle".
  • Update the plugin version content target path to "$(AppData)\Autodesk\ApplicationPlugins\Speckle.Connectors.Navisworks.bundle\Contents$(NavisworksVersion)".

These changes ensure that the correct paths are used for the Navisworks connector plugin bundle and its version content.

…target paths.

- Update the plugin bundle target path to "$(AppData)\Autodesk\ApplicationPlugins\Speckle.Connectors.Navisworks.bundle".
- Update the plugin version content target path to "$(AppData)\Autodesk\ApplicationPlugins\Speckle.Connectors.Navisworks.bundle\Contents\$(NavisworksVersion)".

These changes ensure that the correct paths are used for the Navisworks connector plugin bundle and its version content.
@jsdbroughton jsdbroughton added the bug Something isn't working label Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.24%. Comparing base (13740de) to head (d06ac15).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #464   +/-   ##
=====================================
  Coverage   9.24%   9.24%           
=====================================
  Files        227     227           
  Lines       4260    4260           
  Branches     533     533           
=====================================
  Hits         394     394           
  Misses      3850    3850           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jsdbroughton jsdbroughton enabled auto-merge (squash) December 25, 2024 16:32
@jsdbroughton jsdbroughton enabled auto-merge (squash) December 25, 2024 16:34
@jsdbroughton jsdbroughton merged commit dcc29f3 into dev Dec 25, 2024
5 checks passed
@jsdbroughton jsdbroughton deleted the jonathon/navisworks/bundle-name branch December 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants