Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom assembly resolve for Navisworks #478

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Jan 9, 2025

Add custom assembly resolve for Navisworks to fix Webview conflicts with NW2025

Copy link

linear bot commented Jan 9, 2025

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.17%. Comparing base (5812e1c) to head (47729b3).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #478   +/-   ##
=====================================
  Coverage   9.17%   9.17%           
=====================================
  Files        228     228           
  Lines       4296    4296           
  Branches     542     542           
=====================================
  Hits         394     394           
  Misses      3886    3886           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock force-pushed the adam/cnx-977-navisworks-2025-crashing-when-opening-the-plugin-for-the branch from b740a8d to 9a17bff Compare January 9, 2025 15:24
@adamhathcock adamhathcock changed the title Made two different webview projects to be referenced by connectors Add custom assembly resolve for Navisworks Jan 9, 2025
@adamhathcock adamhathcock marked this pull request as ready for review January 9, 2025 15:25
Copy link
Member

@didimitrie didimitrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust this works, i don't have navis 2025 installed

@adamhathcock adamhathcock enabled auto-merge (squash) January 10, 2025 09:26
@adamhathcock adamhathcock merged commit c5d37a1 into dev Jan 10, 2025
5 checks passed
@adamhathcock adamhathcock deleted the adam/cnx-977-navisworks-2025-crashing-when-opening-the-plugin-for-the branch January 10, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navisworks 2025 crashing when opening the plugin for the beta connector
2 participants