Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Event Aggregator with Revit #513

Merged
merged 16 commits into from
Jan 24, 2025
Merged

Use Event Aggregator with Revit #513

merged 16 commits into from
Jan 24, 2025

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Jan 22, 2025

replaces #502

updates Revit to use Event Aggregator
EA can now have static handlers again

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.86%. Comparing base (4b5f398) to head (08e89d3).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...tShared/Settings/RevitConversionSettingsFactory.cs 0.00% 2 Missing ⚠️
...le.Connectors.DUI/Eventing/OneTimeThreadedEvent.cs 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #513      +/-   ##
==========================================
+ Coverage   14.74%   15.86%   +1.12%     
==========================================
  Files         239      238       -1     
  Lines        4674     4721      +47     
  Branches      576      578       +2     
==========================================
+ Hits          689      749      +60     
+ Misses       3954     3942      -12     
+ Partials       31       30       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review January 23, 2025 11:16
@adamhathcock adamhathcock enabled auto-merge (squash) January 23, 2025 12:34
@JR-Morgan JR-Morgan disabled auto-merge January 24, 2025 12:02
@adamhathcock adamhathcock merged commit ca7714a into dev Jan 24, 2025
5 checks passed
@adamhathcock adamhathcock deleted the revit-event-agg2 branch January 24, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants