bjorn/cnx-1133-user-facing-attributes-not-consistent-for-joints

[bjoernsteinhagen]

Description & Motivation

• Related to CNX-1133
• This was missed in CNX-1112

Changes:

• JOINT to have user-facing attributes like SHELL and FRAME
• All properties occuring more than once moved to Constants.cs to avoid this in the future
• Caught some old strings in the EtabsSendCollectionManager!

Screenshots:

Before Changes

Two occurences of, what should be the same property:

Evident that the "old" camelCase was being used:

After Changes

Filtering by common properties as expected:

Conforming with the other objects:

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

[linear]

CNX-1133 User Facing Attributes Not Consistent for Joints

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.35%. Comparing base (e4a2908) to head (a7e2294).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #536   +/-   ##
=======================================
  Coverage   17.35%   17.35%           
=======================================
  Files         239      239           
  Lines        4805     4805           
  Branches      579      579           
=======================================
  Hits          834      834           
  Misses       3941     3941           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.