Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to sqlite exceptions #198

Merged
merged 36 commits into from
Jan 9, 2025

Add throwing tests

b5060c4
Select commit
Loading
Failed to load commit list.
Merged

Add details to sqlite exceptions #198

Add throwing tests
b5060c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

68.38% (+12.09%) compared to ed5bdc9

View this Pull Request on Codecov

68.38% (+12.09%) compared to ed5bdc9

Details

Codecov Report

Attention: Patch coverage is 91.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.38%. Comparing base (ed5bdc9) to head (b5060c4).

Files with missing lines Patch % Lines
src/Speckle.Sdk/SQLite/SqLiteJsonCacheException.cs 37.50% 3 Missing and 7 partials ⚠️
src/Speckle.Sdk/SQLite/CacheDbCommandPool.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #198       +/-   ##
===========================================
+ Coverage   56.28%   68.38%   +12.09%     
===========================================
  Files         244      263       +19     
  Lines        9879    10658      +779     
  Branches     1086     1094        +8     
===========================================
+ Hits         5560     7288     +1728     
+ Misses       4063     3015     -1048     
- Partials      256      355       +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.