Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellation rework for Receive #216

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

linear bot commented Jan 27, 2025

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 87.45520% with 35 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (f0c7169) to head (3637406).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...Sdk.Serialization.Tests/Framework/TestTransport.cs 20.00% 8 Missing ⚠️
...k.Serialization.Tests/Framework/TestFileManager.cs 77.77% 3 Missing and 3 partials ⚠️
Speckle.Sdk.Testing/Framework/ExceptionScrubber.cs 75.00% 2 Missing and 1 partial ⚠️
...c/Speckle.Sdk/Api/Operations/Operations.Receive.cs 0.00% 3 Missing ⚠️
.../Speckle.Sdk.Serialization.Tests/ExceptionTests.cs 92.68% 0 Missing and 3 partials ⚠️
...ation.Tests/Framework/ExceptionSendCacheManager.cs 66.66% 3 Missing ⚠️
...eckle.Sdk/Serialisation/V2/Receive/ObjectLoader.cs 81.81% 2 Missing ⚠️
...on.Tests/Framework/ExceptionServerObjectManager.cs 50.00% 2 Missing ⚠️
...ckle.Sdk.Serialization.Tests/SerializationTests.cs 93.10% 2 Missing ⚠️
...Sdk/Serialisation/V2/Receive/DeserializeProcess.cs 95.83% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #216       +/-   ##
===========================================
+ Coverage   58.07%   70.20%   +12.12%     
===========================================
  Files         251      273       +22     
  Lines       10083    10949      +866     
  Branches     1089     1102       +13     
===========================================
+ Hits         5856     7687     +1831     
+ Misses       3971     2909     -1062     
- Partials      256      353       +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review January 27, 2025 13:49
@JR-Morgan
Copy link
Member

Merged part of #218

@JR-Morgan JR-Morgan closed this Jan 30, 2025
auto-merge was automatically disabled January 30, 2025 13:43

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants