Updated docker compose #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 95 95
Lines 5670 5670
=======================================
Hits 4970 4970
Misses 700 700 ☔ View full report in Codecov by Sentry. |
gjedlicska
approved these changes
Oct 21, 2024
iainsproat
reviewed
Oct 21, 2024
| speckle-frontend: | ||
| image: speckle/speckle-frontend:latest |
There was a problem hiding this comment.
If using FE2, the ingress service is also required: https://github.com/specklesystems/speckle-server/blob/4b4963a75e4b5304474fb17dbeeb8d9e85093e53/docker-compose-speckle.yml#L3-L14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently failing because the health checks were changed some months ago
I've updated the docker compose file with the one we used on the speckle-sharp-sdk repo
which contains a few other tweaks.
Had to keep a frontend service in the file, looks like the
client.server.getfunction relies on being able to fetch the headers from the root server url. Not ideal, but don't immediately know how to work around it so I'm keeping a fe service running (but now updated to fe2)