Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle raw function arguments property #250

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Handle raw function arguments property #250

merged 2 commits into from
Jun 24, 2024

Conversation

Brendonovich
Copy link
Collaborator

Function arguments starting with r# should have it stripped from them

@Brendonovich
Copy link
Collaborator Author

actually this should probably be handled in tauri-specta since stripping r# is done by tauri::command

@Brendonovich
Copy link
Collaborator Author

specta-rs/tauri-specta@92c640d

@Brendonovich
Copy link
Collaborator Author

Brendonovich commented Jun 24, 2024 •
edited
Loading

changed our minds

@Brendonovich Brendonovich reopened this Jun 24, 2024
@oscartbeaumont
Copy link
Member

The logic: r# is removed so the name matches the "actual" value and it's the responsibility of the exporter to add back in the correct escape sequence for whatever language it's exporting to.

You're never gonna want the r# in a non-Rust exporter so striping it feels more logical.

@oscartbeaumont oscartbeaumont merged commit a9022e9 into main Jun 24, 2024
4 of 5 checks passed
@oscartbeaumont oscartbeaumont deleted the raw-function-args branch June 24, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscartbeaumont oscartbeaumont oscartbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brendonovich @oscartbeaumont