Skip to content

Conversation

YannChemin
Copy link
Contributor

No description provided.

@tboggs
Copy link
Member

tboggs commented Oct 16, 2023

Hi,

Thanks for the PR. Could you please make the PR against the develop branch so I can test it prior to merging into master? Also, can you please provide any details about the code like:

  • Does it handle all attributes of the RELab library?
  • Are there any issues/limitations to how it works?
  • Is there any clean-up that still needs to be done (e.g., it looks like the bad_files list may not be relvant here)?

Thanks,
Thomas

@YannChemin
Copy link
Contributor Author

done, plz check the #160

@YannChemin
Copy link
Contributor Author

Hi, have you been able to test?

@YannChemin
Copy link
Contributor Author

Added test

@tboggs tboggs mentioned this pull request Aug 9, 2024
@tboggs
Copy link
Member

tboggs commented Aug 18, 2024

@YannChemin can you confirm whether this PR is the same set of changes as were proposed for the develop branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants