Skip to content

Conversation

@0xced
Copy link
Contributor

@0xced 0xced commented Feb 5, 2025

Fixes #1754

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • No documentation changes are required

Changes

Before this pull request, generic exceptions would be mangled.

0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]: Dummy fault reason
  at void <Main>$(string[] args) in Program.cs:7
Screenshot of the mangled exception

After this pull request, generic exceptions are displayed properly.

FaultException<DriveInfo>: Dummy fault reason
  at void <Main>$(string[] args) in Program.cs:7
Screenshot of the proper exception

Please upvote 👍 this pull request if you are interested in it.

@0xced 0xced force-pushed the fix-generic-exception-formatting branch from 5c92127 to 9d8d3c1 Compare February 5, 2025 17:21
Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patriksvensson patriksvensson merged commit c1eb94c into spectreconsole:main Feb 5, 2025
3 checks passed
@0xced 0xced deleted the fix-generic-exception-formatting branch February 5, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatting of generic exceptions is mangled

2 participants