Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion remove unused XUnit dependency from Spectre.Verify.Extensions #7

Closed
devlead opened this issue Jan 27, 2024 · 0 comments · Fixed by #8
Closed

Suggestion remove unused XUnit dependency from Spectre.Verify.Extensions #7

devlead opened this issue Jan 27, 2024 · 0 comments · Fixed by #8

Comments

@devlead
Copy link
Contributor

devlead commented Jan 27, 2024

Currently, this package depends on Verify.Xunit but I can't see it's being used anywhere.

spectre.verify.extensions/src/Spectre.Verify.Extensions/Spectre.Verify.Extensions.csproj

Line 9 in 95654e1

<PackageReference Include="Verify.Xunit" Version="23.0.0" />

If that's the case my suggestion is to remove it

- <PackageReference Include="Verify.Xunit" Version="23.0.0" />

So this package also can be used with i.e. Verify.NUnit.
devlead added a commit to devlead/spectre.verify.extensions that referenced this issue Jan 27, 2024
@devlead
(spectresystemsGH-7) Remove Verify.XUnit dependency
07358c7 
* fixes spectresystems#7
@devlead devlead mentioned this issue Jan 27, 2024
Merged
patriksvensson pushed a commit that referenced this issue Jan 27, 2024
@devlead @patriksvensson
(GH-7) Remove Verify.XUnit dependency
1575083 
* fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH7: Remove Verify.XUnit dependency devlead/spectre.verify.extensions
1 participant
@devlead