Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: address getting started feedback #4809

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Nov 27, 2024

Describe the Change

This PR addresses the feedback received from users who went through the new Getting Started section.
One example is the feedback left by @benradstone, which can be found here.

Changed Pages

💻 Getting Started

Jira Tickets

🎫 DOC-1493

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@caroldelwing caroldelwing added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. labels Nov 27, 2024
@caroldelwing caroldelwing marked this pull request as ready for review November 27, 2024 16:12
@caroldelwing caroldelwing requested a review from a team as a code owner November 27, 2024 16:12
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 4fcdfaf
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/674744cb1405600008e94b91
😎 Deploy Preview https://deploy-preview-4809--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit a0d7631
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/67487aa41ec1980008d4a92f
😎 Deploy Preview https://deploy-preview-4809--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@benradstone benradstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes! 🥳

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
@caroldelwing caroldelwing merged commit 8402c66 into master Nov 28, 2024
15 checks passed
@caroldelwing caroldelwing deleted the doc-1493-getting-started branch November 28, 2024 14:29
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1
version-4-2
version-4-3
version-4-4
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 28, 2024
* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 29, 2024
* docs: address getting started feedback (#4809)

* docs: address getting started feedback

* docs: vale feedback

* docs: fix typo

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: apply suggestions from code review

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit 8402c66)

* docs: retrigger build

---------

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants