Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency Duplication #5460

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Remove Dependency Duplication #5460

merged 2 commits into from
Jan 16, 2025

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Jan 16, 2025

Describe the Change

This PR aims to address duplicate React context that may have contributed to the 1/15/25 outage. Actions take:

  • Issued npm ddp to remove duplicates.
  • Removed jest-config-docusaurus from package.json. It's outdated and not needed.
  • Issued npm test to verify test suit completed successfully.

Changed Pages

💻 Add Preview URL for Page

Jira Tickets

🎫 Jira Ticket

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner January 16, 2025 18:33
@karl-cardenas-coding karl-cardenas-coding changed the title chore: remove duplicate dependencies Remove Dependency Duplication Jan 16, 2025
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 3fc58cf
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/678965c8384e0400081e5050
😎 Deploy Preview https://deploy-preview-5460--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding added CI/CD CI/CD related changes visual-tests Trigger the visual tests workflow labels Jan 16, 2025
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@caroldelwing caroldelwing added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. labels Jan 16, 2025
@caroldelwing caroldelwing removed the visual-tests Trigger the visual tests workflow label Jan 16, 2025
@caroldelwing caroldelwing merged commit f35968b into master Jan 16, 2025
16 checks passed
@caroldelwing caroldelwing deleted the react-context branch January 16, 2025 20:16
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1
version-4-2
version-4-3
version-4-4
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
Copy link
Contributor

📋 Visual Report for branch react-context with CI run 12816657888 and attempt 1 is ready at
https://spectrocloud.github.io/librarium/reports/react-context/12816657888/1

💡 You may have to wait for DNS to resolve or the GitHub Pages job to complete. You can view the progress of the GitHub Pages job here.

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
(cherry picked from commit f35968b)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. CI/CD CI/CD related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants