Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflag issues when using multiple flags with method='linear' or method='repeat' #1080

Open
jameswilburlewis opened this issue Jan 29, 2025 · 0 comments
Labels
bug Something isn't working pytplot Issues involving the pytplot package refactoring

Comments

@jameswilburlewis
Copy link
Contributor

Deflag can accept multiple user-defined flag values passed in as a single array. If the 'linear' or 'repeat' methods are used with multiple flags,
a situation can arise where, due to a combination of flags, one or more slices through the data contain no unflagged values. But with these methods, deflag only processes one flag at a time, so it doesn't notice the issue if each individual flag leaves some valid data to work with.

For these methods, deflag should 'or' all the flags together for the individual flag values, before deciding whether to attempt to deflag that slice. (So the loop order needs to be inverted....outer loop for the slices, inner loop for the flag array).

This is probably a very uncommon situation, so not necessarily the highest priority....

@jameswilburlewis jameswilburlewis added bug Something isn't working pytplot Issues involving the pytplot package refactoring labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pytplot Issues involving the pytplot package refactoring
Projects
None yet
Development

No branches or pull requests

1 participant