-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @speechmatics/auth
package for JWT creation
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Flow client class based on V1 protocol spec - Implement queuing for agent audio
mnemitz
added a commit
that referenced
this pull request
Oct 29, 2024
## Summary - Use PNPM as package manager instead of NPM, as it has a very smooth out of the box experience for monorepos/workspaces: https://pnpm.io/workspaces - Add `real-time-client` package which is copied from the current Portal RT implementation - Add `batch-client` package which is more or less unchanged, apart from a few enhancements - Add `flow-client` package based on flow app implementation - Add `flow-client-react` package for utility hooks wrapping the Flow client - Use Rollup for building each package following this (wonderful) Github Gist: https://gist.github.com/aleclarson/9900ed2a9a3119d865286b218e14d226 ## Future work After this PR is merged, there are a few pieces of follow-up work: - Use changesets to manage releases: https://github.com/changesets/changesets - Add package for JWT generation across services: #67 - Add utility hooks packages - Add batch/RT examples to NextJS
mnemitz
changed the title
Draft: package for JWT creation
Add Nov 1, 2024
@speechmatics/auth
package for JWT creation
TudorCRL
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm, just one small comment concerning regions
anjz
reviewed
Nov 6, 2024
anjz
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@speechmatics/auth
package which can be used to generate JWTs for batch, real-time and Flow