temp

speedb-io · Sep 12, 2023 · 063a70e · 063a70e
1 parent c771deb
commit 063a70e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 22 deletions.
diff --git a/options/options.cc b/options/options.cc
@@ -629,11 +629,10 @@ ColumnFamilyOptions* ColumnFamilyOptions::EnableSpeedbFeaturesCF(
     assert(s.ok());
     block_based_table_options.cache_index_and_filter_blocks = true;  
     block_based_table_options.block_cache = shared_options.cache;
-    auto& cache_usage_options = block_based_table_options.cache_usage_options;
     std::string pinning_policy_s = "id=speedb_scoped_pinning_policy; capacity=";
     pinning_policy_s += 0.8 * shared_options.GetTotalRamSizeBytes();
     pinning_policy_s += "; bottom_percent=60; mid_percent=75";
-    Status s = TablePinningPolicy::CreateFromString(config_options, 
+    s = TablePinningPolicy::CreateFromString(config_options, 
     pinning_policy_s,
      &block_based_table_options.pinning_policy);
 

diff --git a/options/options_test.cc b/options/options_test.cc
@@ -5092,26 +5092,6 @@ TEST_F(SharedOptionsTest, EnableSpeedbFeaturesCF) {
   for (auto options_overrides_iter = sanitized_options_overrides.cbegin();
        options_overrides_iter != sanitized_options_overrides.cend();
        ++options_overrides_iter) {
-    CacheEntryRoleOptions role_options = options_overrides_iter->second;
-    CacheEntryRoleOptions default_options =
-        sanitized_table_options->cache_usage_options.options;
-    if (options_overrides_iter->first == CacheEntryRole::kFilterConstruction) {
-      ASSERT_EQ(role_options.charged,
-                CacheEntryRoleOptions::Decision::kEnabled);
-    } else if (options_overrides_iter->first ==
-               CacheEntryRole::kBlockBasedTableReader) {
-      ASSERT_EQ(role_options.charged,
-                CacheEntryRoleOptions::Decision::kEnabled);
-    } else if (options_overrides_iter->first ==
-               CacheEntryRole::kCompressionDictionaryBuildingBuffer) {
-      ASSERT_EQ(role_options.charged,
-                CacheEntryRoleOptions::Decision::kEnabled);
-    } else if (options_overrides_iter->first == CacheEntryRole::kFileMetadata) {
-      ASSERT_EQ(role_options.charged,
-                CacheEntryRoleOptions::Decision::kEnabled);
-    } else {
-      EXPECT_TRUE(role_options == default_options);
-    }
   }
 }