Skip to content

Commit

Permalink
db_bench: allow setting avoid_unnecessary_blocking_io (#183)
Browse files Browse the repository at this point in the history
This would allow us to compare the performance of changes related to
background purges using db_bench.
  • Loading branch information
isaac-io committed Sep 29, 2022
1 parent 6359b58 commit 23da5d2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tools/db_bench_tool.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1554,6 +1554,10 @@ DEFINE_bool(persist_stats_to_disk,
DEFINE_uint64(stats_history_buffer_size,
ROCKSDB_NAMESPACE::Options().stats_history_buffer_size,
"Max number of stats snapshots to keep in memory");
DEFINE_bool(avoid_unnecessary_blocking_io,
ROCKSDB_NAMESPACE::Options().avoid_unnecessary_blocking_io,
"If true, some expensive cleaning up operations will be moved from "
"user threads to background threads.");
DEFINE_bool(avoid_flush_during_recovery,
ROCKSDB_NAMESPACE::Options().avoid_flush_during_recovery,
"If true, avoids flushing the recovered WAL data where possible.");
Expand Down Expand Up @@ -4328,6 +4332,7 @@ class Benchmark {
options.persist_stats_to_disk = FLAGS_persist_stats_to_disk;
options.stats_history_buffer_size =
static_cast<size_t>(FLAGS_stats_history_buffer_size);
options.avoid_unnecessary_blocking_io = FLAGS_avoid_unnecessary_blocking_io;
options.avoid_flush_during_recovery = FLAGS_avoid_flush_during_recovery;

options.compression_opts.level = FLAGS_compression_level;
Expand Down

0 comments on commit 23da5d2

Please sign in to comment.