Skip to content

Commit

Permalink
SPDB-516: remove enforcement of bytes per sync
Browse files Browse the repository at this point in the history
  • Loading branch information
Yuval-Ariel committed May 19, 2022
1 parent 042e1f9 commit 6547c56
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions db/db_impl/db_impl_open.cc
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,16 @@ DBOptions SanitizeOptions(const std::string& dbname, const DBOptions& src,
result.env->IncBackgroundThreadsIfNeeded(bg_job_limits.max_flushes,
Env::Priority::HIGH);

result.bytes_per_sync = 0;
// TODO: explain why spdb doesnt use rate_limiter
result.rate_limiter.reset();
// as part of SPDB-516
#if 0
if (result.rate_limiter.get() != nullptr) {
result.rate_limiter.reset();
if (result.bytes_per_sync == 0) {
result.bytes_per_sync = 1024 * 8;
result.bytes_per_sync = 1024 * 1024;
}
}
#endif

if (result.delayed_write_rate == 0) {
if (result.rate_limiter.get() != nullptr) {
Expand Down
2 changes: 1 addition & 1 deletion speedb/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#define SPEEDB_MAJOR 1
#define SPEEDB_MINOR 5
#define SPEEDB_PATCH 22
#define SPEEDB_PATCH 23

namespace ROCKSDB_NAMESPACE {
// Returns the current version of SpeeDB as a string (e.g. "1.5.0").
Expand Down

0 comments on commit 6547c56

Please sign in to comment.