Skip to content

Commit

Permalink
db_bench: allow setting avoid_unnecessary_blocking_io (#183)
Browse files Browse the repository at this point in the history
This would allow us to compare the performance of changes related to
background purges using db_bench.
  • Loading branch information
isaac-io authored and Yuval-Ariel committed Apr 25, 2023
1 parent e97f166 commit 7f0509d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tools/db_bench_tool.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1669,6 +1669,10 @@ DEFINE_bool(persist_stats_to_disk,
DEFINE_uint64(stats_history_buffer_size,
ROCKSDB_NAMESPACE::Options().stats_history_buffer_size,
"Max number of stats snapshots to keep in memory");
DEFINE_bool(avoid_unnecessary_blocking_io,
ROCKSDB_NAMESPACE::Options().avoid_unnecessary_blocking_io,
"If true, some expensive cleaning up operations will be moved from "
"user threads to background threads.");
DEFINE_bool(avoid_flush_during_recovery,
ROCKSDB_NAMESPACE::Options().avoid_flush_during_recovery,
"If true, avoids flushing the recovered WAL data where possible.");
Expand Down Expand Up @@ -4076,6 +4080,7 @@ class Benchmark {
options.stats_history_buffer_size =
static_cast<size_t>(FLAGS_stats_history_buffer_size);
options.avoid_flush_during_recovery = FLAGS_avoid_flush_during_recovery;
options.avoid_unnecessary_blocking_io = FLAGS_avoid_unnecessary_blocking_io;

options.compression_opts.level = FLAGS_compression_level;
options.compression_opts.max_dict_bytes = FLAGS_compression_max_dict_bytes;
Expand Down

0 comments on commit 7f0509d

Please sign in to comment.