Unit tests: Disable stuck tests in db_compaction_test (#711)

speedb-io · Oct 15, 2023 · bedf640 · bedf640
1 parent 877f2a5
commit bedf640
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -18,6 +18,7 @@ Fix RepeatableThread to work properly with on thread start callback feature (htt
 * Fix a JAVA build issue introduced by #597 (#680)
 
 ### Miscellaneous
+* Unit tests: Disable CancelCompactionWaitingOnConflict and CompactionLimiter in db_compaction_test since they sometimes fail or get stuck. These need to be investigated and reenabled.
 
 ## Grapes v2.6.0 (8/22/2023)
 Based on RocksDB 8.1.1

diff --git a/db/db_compaction_test.cc b/db/db_compaction_test.cc
@@ -3913,7 +3913,8 @@ TEST_P(DBCompactionTestWithParam, FullCompactionInBottomPriThreadPool) {
   Env::Default()->SetBackgroundThreads(0, Env::Priority::BOTTOM);
 }
 
-TEST_P(DBCompactionTestWithParamWithMCC, CancelCompactionWaitingOnConflict) {
+TEST_P(DBCompactionTestWithParamWithMCC,
+       DISABLED_CancelCompactionWaitingOnConflict) {
   // This test verifies cancellation of a compaction waiting to be scheduled due
   // to conflict with a running compaction.
   //
@@ -5720,7 +5721,7 @@ TEST_F(DBCompactionTest, CompactionHasEmptyOutput) {
   ASSERT_EQ(2, collector->num_ssts_creation_started());
 }
 
-TEST_P(DBCompactionTestWithMCC, CompactionLimiter) {
+TEST_P(DBCompactionTestWithMCC, DISABLED_CompactionLimiter) {
   const int kNumKeysPerFile = 10;
   const int kMaxBackgroundThreads = 64;