Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: allow running unit test from plugins as part of make check #123

Closed
isaac-io opened this issue Aug 16, 2022 · 0 comments · Fixed by #143
Closed

tests: allow running unit test from plugins as part of make check #123

isaac-io opened this issue Aug 16, 2022 · 0 comments · Fixed by #143
Assignees
@mrambacher @isaac-io
Labels
build Build related enhancement New feature or request Upstreamable can be upstreamed to RocksDB
Milestone
v2.1.0

Comments

@isaac-io
Copy link
Contributor

Currently the plugin infra supports adding sources, include directories, and libraries to the build. However, it doesn't allow compiling and running unit tests that originated in plugins. Add the ability to do so using a ${plugin}_TESTS variable.
@isaac-io isaac-io added enhancement New feature or request Upstreamable can be upstreamed to RocksDB build Build related labels Aug 16, 2022
@isaac-io isaac-io linked a pull request Aug 30, 2022 that will close this issue
Add Plugin Tests to builds #143
Merged
@isaac-io isaac-io mentioned this issue Sep 12, 2022
Closed
isaac-io pushed a commit that referenced this issue Sep 13, 2022
@mrambacher
plugins: add Plugin Tests to builds (#123)
4691752 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
@isaac-io isaac-io added this to the v2.1.0 milestone Sep 21, 2022
isaac-io pushed a commit that referenced this issue Oct 19, 2022
@mrambacher @isaac-io
plugins: add Plugin Tests to builds (#123)
3c42d3c 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
isaac-io pushed a commit that referenced this issue Oct 19, 2022
@mrambacher @isaac-io
plugins: add Plugin Tests to builds (#123)
c202d1d 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
isaac-io pushed a commit that referenced this issue Oct 19, 2022
@mrambacher @isaac-io
plugins: add Plugin Tests to builds (#123)
68645ee 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
isaac-io pushed a commit that referenced this issue Oct 19, 2022
@mrambacher @isaac-io
plugins: add Plugin Tests to builds (#123)
32be012 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
isaac-io pushed a commit that referenced this issue Oct 19, 2022
@mrambacher @isaac-io
plugins: add Plugin Tests to builds (#123)
4aef25f 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@mrambacher @Yuval-Ariel
plugins: add Plugin Tests to builds (#123)
c378b0f 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@mrambacher @Yuval-Ariel
plugins: add Plugin Tests to builds (#123)
c13de62 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
@isaac-io isaac-io mentioned this issue Jan 4, 2023
Closed
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@mrambacher @Yuval-Ariel
plugins: add Plugin Tests to builds (#123)
2e732b9 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
udi-speedb pushed a commit that referenced this issue Oct 31, 2023
@mrambacher @udi-speedb
plugins: add Plugin Tests to builds (#123)
b41839f 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
@mrambacher @udi-speedb
plugins: add Plugin Tests to builds (#123)
8385497 
Allow plugins to compile and run their unit tests as part of the
Speedb build and test runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrambacher mrambacher

@isaac-io isaac-io

Labels
build Build related enhancement New feature or request Upstreamable can be upstreamed to RocksDB
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Add Plugin Tests to builds speedb-io/speedb
3 participants
@mrambacher @isaac-io @assaf-speedb