Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix Java test depedndencies in the Makefile #128

Closed
isaac-io opened this issue Aug 19, 2022 · 0 comments · Fixed by #129
Closed

build: fix Java test depedndencies in the Makefile #128

isaac-io opened this issue Aug 19, 2022 · 0 comments · Fixed by #129
Assignees
Labels
bug Something isn't working build Build related Upstreamable can be upstreamed to RocksDB
Milestone

Comments

@isaac-io
Copy link
Contributor

The target dependencies are incorrectly specified for the test target in java/Makefile. This causes it sometime fail when make is invoked in job server mode (-j set a something other than 1). Fix the target dependencies so that the tests are run only after everything was built.

@isaac-io isaac-io added bug Something isn't working Upstreamable can be upstreamed to RocksDB build Build related labels Aug 19, 2022
@isaac-io isaac-io self-assigned this Aug 19, 2022
isaac-io added a commit that referenced this issue Aug 19, 2022
The `test` target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
@isaac-io isaac-io linked a pull request Aug 19, 2022 that will close this issue
isaac-io added a commit that referenced this issue Aug 21, 2022
The `test` target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
@isaac-io isaac-io added this to the v2.1.0 milestone Sep 21, 2022
isaac-io added a commit that referenced this issue Oct 19, 2022
The `test` target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
isaac-io added a commit that referenced this issue Oct 19, 2022
The `test` target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
isaac-io added a commit that referenced this issue Oct 19, 2022
The `test` target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
isaac-io added a commit that referenced this issue Oct 19, 2022
The `test` target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
isaac-io added a commit that referenced this issue Oct 19, 2022
The `test` target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
The test target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
The test target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
The test target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
udi-speedb pushed a commit that referenced this issue Oct 31, 2023
The test target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
The test target in the Java Makefile has an incorrect dependency graph
that could cause tests to start executing before the compilation finished
(or even started) when make is invoked in job server mode.

Fix it by specifying target dependencies such that running the tests depends
on having the tests compiled first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Build related Upstreamable can be upstreamed to RocksDB
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant