Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bloom_test: compilation failures with GCC #136

Closed
isaac-io opened this issue Aug 24, 2022 · 0 comments · Fixed by #137
Closed

bloom_test: compilation failures with GCC #136

isaac-io opened this issue Aug 24, 2022 · 0 comments · Fixed by #137
Assignees
@isaac-io
Labels
build Build related Upstreamable can be upstreamed to RocksDB
Milestone
v2.1.0

Comments

@isaac-io
Copy link
Contributor

Compiling bloom_test with GCC 12 results in the following error:

util/bloom_test.cc: In constructor ‘rocksdb::RawFilterTester::RawFilterTester()’:
util/bloom_test.cc:1012:40: error: member ‘rocksdb::RawFilterTester::data_’ is used uninitialized [-Werror=uninitialized]
 1012 |   RawFilterTester() : metadata_ptr_(&*(data_.end() - 5)) {}
      |                                        ^~~~~

To Reproduce

Run make bloom_test

Expected behavior

Compilation succeeds.

Additional context

N/A
@isaac-io isaac-io added Upstreamable can be upstreamed to RocksDB build Build related labels Aug 24, 2022
@isaac-io isaac-io self-assigned this Aug 24, 2022
isaac-io added a commit that referenced this issue Aug 24, 2022
@isaac-io
bloom_test: fix compilation error with GCC 12 (#136)
f74c31a 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
@isaac-io isaac-io linked a pull request Aug 24, 2022 that will close this issue
bloom_test: fix compilation error with GCC 12 (#136) #137
Merged
isaac-io added a commit that referenced this issue Aug 24, 2022
@isaac-io
bloom_test: fix compilation error with GCC 12 (#136)
36c02c4 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
@isaac-io isaac-io added this to the v2.1.0 milestone Sep 21, 2022
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
bloom_test: fix compilation error with GCC 12 (#136)
441e4b4 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
bloom_test: fix compilation error with GCC 12 (#136)
77d997f 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
bloom_test: fix compilation error with GCC 12 (#136)
c0c0f3a 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
bloom_test: fix compilation error with GCC 12 (#136)
f3028c4 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
bloom_test: fix compilation error with GCC 12 (#136)
b833ef8 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@isaac-io @Yuval-Ariel
bloom_test: fix compilation error with GCC 12 (#136)
b9ac079 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
bloom_test: fix compilation error with GCC 12 (#136)
96287ff 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
bloom_test: fix compilation error with GCC 12 (#136)
426dff3 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
udi-speedb pushed a commit that referenced this issue Oct 31, 2023
@isaac-io @udi-speedb
bloom_test: fix compilation error with GCC 12 (#136)
4528315 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
@isaac-io @udi-speedb
bloom_test: fix compilation error with GCC 12 (#136)
f53c0d0 
When compiling bloom_test with GCC 12 it complains about using uninitialised
variables. The error is technically wrong, since only the address is taken,
but since this is a test and there's no performance penalty, initialise
the member to get rid of the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaac-io isaac-io

Labels
build Build related Upstreamable can be upstreamed to RocksDB
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

bloom_test: fix compilation error with GCC 12 (#136) speedb-io/speedb
1 participant
@isaac-io