tests: crash tests are failing due to running out of space #140
Assignees
Labels
Milestone
Comments
isaac-io
added
bug
isaac-io
added a commit
that referenced
this issue
Aug 25, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Sep 16, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Sep 16, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
isaac-io
added a commit
that referenced
this issue
Oct 24, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
Yuval-Ariel
pushed a commit
that referenced
this issue
Nov 23, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
Yuval-Ariel
pushed a commit
that referenced
this issue
Nov 25, 2022
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
Yuval-Ariel
pushed a commit
that referenced
this issue
Apr 30, 2023
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
udi-speedb
pushed a commit
that referenced
this issue
Oct 31, 2023
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
udi-speedb
pushed a commit
that referenced
this issue
Dec 3, 2023
The changes in #119 included an upstream commit that moved the TEST_TMPDIR setting to common.mk and executed it unconditionally. This is causing pollution of /dev/shm unnecessarily, and also causes the crash tests and other targets to use /dev/shm when they originally didn't. On machines with small /dev/shm this leads to the crash tests failing with an out of space error. Make the setting of TEST_TMPDIR and the creation of a temporary directory under it execute only once during a single make invocation and only for the check target, as it was originally. This requires dealing with make restarts (due to makefiles getting remade) in the form of adding another temporary configuration file named test_config.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#119 included a commit from upstream that started setting
TEST_TEMPDIRregardless of which target was chosen. The original code only did that in case the target wascheck. The new behaviour is causing all targets that are running code that relies onTEST_TMPDIRto start storing things in/dev/shm, and on machines with a small/dev/shmthis causes the tests to fail (this is actually happening to us in CI right now. See https://github.com/speedb-io/speedb/runs/8020593491?check_suite_focus=true).While we can change the CI workflow to explicitly set
TMPDas we do for the unit tests, since this is a change in behaviour we should probably change the code so that the original behavior is restored.To Reproduce
make crash_teston a machine with a small/dev/shmmounted.Expected behavior
Crash tests don't fail due to running out of space.
Additional context
N/A
The text was updated successfully, but these errors were encountered: