Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: logos render in a broken manner #149

Closed
isaac-io opened this issue Aug 30, 2022 · 3 comments · Fixed by #181
Closed

README: logos render in a broken manner #149

isaac-io opened this issue Aug 30, 2022 · 3 comments · Fixed by #181
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@isaac-io
Copy link
Contributor

isaac-io commented Aug 30, 2022

After the merge of #135, rendering of the repo page and the readme page is broken on mobile (horizontal scrolling is activated and the logo is partially hidden) due to the heading logo having a fixed width, instead of a relative width with a max-width:

image

Additionally, on desktop with dark mode the logos look bad, and the bee is almost invisible:

image

@isaac-io isaac-io added the documentation Improvements or additions to documentation label Aug 30, 2022
@rtpro
Copy link
Contributor

rtpro commented Sep 14, 2022

@isaac-io

  1. Image Size - I've tested the image size issue, and it looks okay on Pixel 6.

What device and browser are you using?

  1. Dark Mode - I'm checking what can be done with the images to look better with Dark mode.

@isaac-io
Copy link
Contributor Author

What device and browser are you using?

My screenshot was from Firefox Mobile on a Motorola device, but it seems to render fine now. There seems to have been a change on GitHub's side in the mean time (the image now has style="max-width: 100%; display: inline-block;" applied to it), so you can disregard that issue.

@rtpro
Copy link
Contributor

rtpro commented Sep 28, 2022

Update: awaiting shiny new graphics compatible with Dark Mode.

@rtpro rtpro linked a pull request Sep 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants