Adding logo to readme #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-io
reviewed
Aug 23, 2022
README.md
Outdated
Comment on lines
1
to
3
| <img src="speedb-logo.gif" /> | ||
|
|
||
| # Speedb |
There was a problem hiding this comment.
This renders way too large on my screens. Can we get someone from marketing to look at it and set the right size? Also, the Speedb header seems to be a bit redundant with this logo which already spells it out. I think it should be removed and instead the image should have Speedb logo as its alt text (so it's searchable and also so that visually impaired users as well as those with broken Internet connections can know what it's about).
README.md
Outdated
Comment on lines
82
to
83
|
|
||
| <img src="speedb-b.gif" /> |
There was a problem hiding this comment.
This seems a bit redundant to me, but as an engineer I'm probably the wrong person to comment on this. Can we get someone from marketing to review this?
maxb-io
approved these changes
Aug 30, 2022
Yuval-Ariel
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Adding logo and badges to readme
Yuval-Ariel
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Adding logo and badges to readme
Yuval-Ariel
pushed a commit
that referenced
this pull request
Apr 30, 2023
* Adding logo and badges to readme
udi-speedb
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Adding logo and badges to readme
udi-speedb
pushed a commit
that referenced
this pull request
Dec 3, 2023
* Adding logo and badges to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.