Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: speed up test runs startup time #174

Closed
isaac-io opened this issue Sep 21, 2022 · 1 comment · Fixed by #175
Closed

makefile: speed up test runs startup time #174

isaac-io opened this issue Sep 21, 2022 · 1 comment · Fixed by #175
Assignees
@isaac-io @assaf-speedb
Labels
build Build related enhancement New feature or request Upstreamable can be upstreamed to RocksDB
Milestone
v2.1.0

Comments

@isaac-io
Copy link
Contributor

The Makefile has many places where it needlessly invokes a sub-make instead of declaring the dependencies correctly. This is causing slowdowns on startup, and especially noticeable during test runs (make check) where each time a sub-make is invoked it regenerates make_config.mk and that takes a long time. Rework the dependency graph so that at least running tests doesn't involve invoking make three times.
@isaac-io isaac-io self-assigned this Sep 21, 2022
@isaac-io isaac-io added enhancement New feature or request Upstreamable can be upstreamed to RocksDB build Build related labels Sep 21, 2022
isaac-io added a commit that referenced this issue Sep 21, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
959c66c 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
@isaac-io isaac-io linked a pull request Sep 21, 2022 that will close this issue
makefile: rework the dependency graph for faster test runs startup (#… #175
Merged
@isaac-io isaac-io added this to the v2.1.0 milestone Sep 21, 2022
isaac-io added a commit that referenced this issue Sep 23, 2022
@isaac-io
Address CR review comments (#174)
0846390
isaac-io added a commit that referenced this issue Sep 23, 2022
@isaac-io
Address review comments (#174)
ec3f7e3
isaac-io added a commit that referenced this issue Sep 25, 2022
@isaac-io
Address another review comment (#174)
e95d937
isaac-io added a commit that referenced this issue Sep 28, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
34c1650 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 3, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
871ff30 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
@Yuval-Ariel
Copy link
Contributor

QA passed

isaac-io added a commit that referenced this issue Oct 3, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
cb4e649 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 3, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
3132712 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
f45495e 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
6cb7be6 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
6ca688d 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
d04c549 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
5aefe73 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 24, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
49ba1bf 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
isaac-io added a commit that referenced this issue Oct 24, 2022
@isaac-io
makefile: rework the dependency graph for faster test runs startup (#174
dcbdd47 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@isaac-io @Yuval-Ariel
makefile: rework the dependency graph for faster test runs startup (#174
b9943fb 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
makefile: rework the dependency graph for faster test runs startup (#174
2dbc6bb 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
makefile: rework the dependency graph for faster test runs startup (#174
544e0f9 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
@isaac-io @Yuval-Ariel
makefile: rework the dependency graph for faster test runs startup (#174
f0eeb55 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
@isaac-io @udi-speedb
makefile: rework the dependency graph for faster test runs startup (#174
98455bf 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
@isaac-io @udi-speedb
makefile: rework the dependency graph for faster test runs startup (#174
9086e70 
)

The Makefile has many places where it needlessly invokes a sub-make instead
of declaring the dependencies correctly. Rework the dependency graph so
that at least running tests doesn't involve invoking make three times.

This also avoids pollution in /dev/shm caused by the needless creation of
temporary directories on make restarts and sub-make invocations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaac-io isaac-io

@assaf-speedb assaf-speedb

Labels
build Build related enhancement New feature or request Upstreamable can be upstreamed to RocksDB
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

makefile: rework the dependency graph for faster test runs startup (#… speedb-io/speedb
3 participants
@isaac-io @Yuval-Ariel @assaf-speedb