Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel make check fails on the first run #177

Closed
isaac-io opened this issue Sep 23, 2022 · 0 comments · Fixed by #178
Closed

Parallel make check fails on the first run #177

isaac-io opened this issue Sep 23, 2022 · 0 comments · Fixed by #178
Assignees
Labels
bug Something isn't working build Build related
Milestone

Comments

@isaac-io
Copy link
Contributor

After the changes in #141, when running make check for the first time after a make clean with GNU Parallel installed, the following message is printed by GNU Parallel and the run fails:

Option tmpdir requires an argument

Subsequent invocations of make check succeed.

To Reproduce

Steps to reproduce the behavior:

  1. make clean
  2. Ensure GNU Parallel is installed
  3. make -j$(nproc) check

Expected behavior

Unit tests successfully run on the first make check invocation after a make clean

System (please complete the following information):

  • OS: Ubuntu 22.04
  • Compiler: GCC 12.2.0

Additional context

N/A.

@isaac-io isaac-io self-assigned this Sep 23, 2022
@isaac-io isaac-io added bug Something isn't working build Build related labels Sep 23, 2022
@isaac-io isaac-io added this to the v2.1.0 milestone Sep 23, 2022
isaac-io added a commit that referenced this issue Sep 23, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Sep 23, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
udi-speedb pushed a commit that referenced this issue Sep 29, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Sep 29, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Sep 29, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Oct 19, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Oct 19, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Oct 19, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Oct 19, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Oct 19, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
isaac-io added a commit that referenced this issue Oct 24, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
After the changes in #141, parallel `make check` started failing with the
following GNU Parallel error:

> Option tmpdir requires an argument

This is caused by the fact that `test_config.mk` uses `?=` for setting
`TEST_TMPDIR` and on make restarts this doesn't work for some reason
(perhaps having to do with empty `TEST_TMPDIR` being somehow exported).

Replace it with a check for empty value and unconditional assignment
instead. While at it, include `test_config.mk` only on make restarts for
check targets instead of forcing everything that makes use of `TEST_TMPDIR`
to reuse the unit tests configuration.

Also use 6 Xs for the mktemp template in order to support BusyBox mktemp
and maybe some others as well, that require the template to end with 6 Xs
exactly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Build related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant