Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paired bloom filter files are missing the correct copyright notice #199

Closed
isaac-io opened this issue Oct 24, 2022 · 0 comments · Fixed by #204
Closed

Paired bloom filter files are missing the correct copyright notice #199

isaac-io opened this issue Oct 24, 2022 · 0 comments · Fixed by #204
Assignees
Milestone

Comments

@isaac-io
Copy link
Contributor

isaac-io commented Oct 24, 2022

With the merging of #54, the following files are now missing the Speedb copyright notice or have the wrong one:

  • plugin/speedb/paired_filter/speedb_db_bloom_filter_test.cc
  • plugin/speedb/paired_filter/speedb_paired_bloom.cc
  • plugin/speedb/paired_filter/speedb_paired_bloom.h
  • plugin/speedb/paired_filter/speedb_paired_bloom_internal.cc
  • plugin/speedb/paired_filter/speedb_paired_bloom_internal.h
  • plugin/speedb/speedb_customizable_test.cc

To Reproduce

N/A

Expected behavior

All of these files should have the following Speedb copyright notice at the beginning as required by the contribution guidelines:

// Copyright (C) 2022 Speedb Ltd. All rights reserved.
// 
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// 
//   http://www.apache.org/licenses/LICENSE-2.0
// 
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Additional context

N/A

@isaac-io isaac-io added this to the v2.1.0 milestone Oct 24, 2022
isaac-io added a commit that referenced this issue Oct 24, 2022
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
@isaac-io isaac-io linked a pull request Oct 24, 2022 that will close this issue
rtpro pushed a commit that referenced this issue Oct 24, 2022
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
isaac-io added a commit that referenced this issue Oct 24, 2022
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
Yuval-Ariel pushed a commit that referenced this issue Nov 24, 2022
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
The paired Bloom filter files are either missing a copyright notice and
licence header, or contain the wrong one. Fix that in order to adhere
to the contribution guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants