Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: randomise test runs and clean up the tests directory on successful runs #202

Closed
isaac-io opened this issue Oct 24, 2022 · 0 comments · Fixed by #203
Closed

cmake: randomise test runs and clean up the tests directory on successful runs #202

isaac-io opened this issue Oct 24, 2022 · 0 comments · Fixed by #203
Assignees
Labels
enhancement New feature or request tests Upstreamable can be upstreamed to RocksDB
Milestone

Comments

@isaac-io
Copy link
Contributor

After the changes in #103 we are now able to run the tests in parallel and use /dev/shm automatically when available. However, tests leave some garbage after them and it accumulates and fills up /dev/shm. Add cleanup code to remove the created directory on successful runs.

While at it, ask ctest to randomise test scheduling in order to increase the likelihood of surfacing bugs.

@isaac-io isaac-io added enhancement New feature or request tests labels Oct 24, 2022
@isaac-io isaac-io added this to the v2.1.0 milestone Oct 24, 2022
@isaac-io isaac-io self-assigned this Oct 24, 2022
isaac-io added a commit that referenced this issue Oct 24, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
@isaac-io isaac-io added the Upstreamable can be upstreamed to RocksDB label Oct 24, 2022
isaac-io added a commit that referenced this issue Oct 25, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
isaac-io added a commit that referenced this issue Oct 25, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
@isaac-io isaac-io modified the milestones: v2.1.0, v2.2.0 Oct 26, 2022
isaac-io added a commit that referenced this issue Oct 26, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
isaac-io added a commit that referenced this issue Oct 26, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
Yuval-Ariel pushed a commit that referenced this issue Nov 15, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
udi-speedb pushed a commit that referenced this issue Nov 15, 2023
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
In the case where we create the test path, we should clean up after the
run finishes as done in the Makefile, due to garbage that is left behind
by tests and accumulates.

While at it, randomise test scheduling in order to increase the likelihood
of surfacing latent bugs that are hidden by the execution order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Upstreamable can be upstreamed to RocksDB
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant