Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: release builds get a build tag #228

Closed
isaac-io opened this issue Nov 10, 2022 · 0 comments · Fixed by #230
Closed

CI: release builds get a build tag #228

isaac-io opened this issue Nov 10, 2022 · 0 comments · Fixed by #230
Assignees
@isaac-io
Labels
bug Something isn't working build Build related ci
Milestone
v2.2.0

Comments

@isaac-io
Copy link
Contributor

After the changes in #156, if spdb_get_build_tag.py doesn't return anything, the build will automatically get a tag of ? unless SPDB_RELEASE_BUILD is specified. CI doesn't specify this, so release builds will get this tag in the next version.

To Reproduce

  1. Tag a release using the GitHub action
  2. Watch the artefacts gets built with a tag of ?

Expected behavior

No build tag is added to released artefacts.

Additional context

N/A
@isaac-io isaac-io added bug Something isn't working build Build related ci labels Nov 10, 2022
@isaac-io isaac-io added this to the v2.2.0 milestone Nov 10, 2022
@isaac-io isaac-io self-assigned this Nov 10, 2022
isaac-io added a commit that referenced this issue Nov 10, 2022
@isaac-io
ci: build a release without a debug tag (#228)
f7ef325 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
@isaac-io isaac-io linked a pull request Nov 10, 2022 that will close this issue
ci: build a release without a debug tag (#228) #230
Merged
isaac-io added a commit that referenced this issue Nov 12, 2022
@isaac-io
ci: build a release without a debug tag (#228)
aff100f 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
Yuval-Ariel pushed a commit that referenced this issue Nov 15, 2022
@isaac-io @Yuval-Ariel
ci: build a release without a debug tag (#228)
442bfff 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
ci: build a release without a debug tag (#228)
99e623a 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
ci: build a release without a debug tag (#228)
ab71baa 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
ci: build a release without a debug tag (#228)
2f2e344 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
ci: build a release without a debug tag (#228)
0707de7 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
@isaac-io @Yuval-Ariel
ci: build a release without a debug tag (#228)
90514aa 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
@isaac-io @udi-speedb
ci: build a release without a debug tag (#228)
9e0cf41 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
udi-speedb pushed a commit that referenced this issue Nov 15, 2023
@isaac-io @udi-speedb
ci: build a release without a debug tag (#228)
d392136 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
@isaac-io @udi-speedb
ci: build a release without a debug tag (#228)
62439d5 
Specify `SPDB_RELEASE_BUILD` to both CMake and the Makefile builds in order
to get the release artefacts to build without a build tag of `?`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaac-io isaac-io

Labels
bug Something isn't working build Build related ci
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

ci: build a release without a debug tag (#228) speedb-io/speedb
1 participant
@isaac-io