Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_bench: bug ErrorExit called on static function #277

Closed
Yuval-Ariel opened this issue Nov 28, 2022 · 0 comments
Closed

db_bench: bug ErrorExit called on static function #277

Yuval-Ariel opened this issue Nov 28, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Yuval-Ariel
Copy link
Contributor

ErrorExit from the Benchmark namespace was called on a static function which led to the error :
tools/db_bench_tool.cc:3276:67: error: cannot call member function ‘void rocksdb::Benchmark::ErrorExit(const char*, ...)’ without object 3276 | ErrorExit("Old clock cache implementation has been removed.");

fix: call the outer scope ErrorExit function.

also, remove the need to add an exit(1) after ErrorExit to stop compiler complaining about :
error: control reaches end of non-void function

@Yuval-Ariel Yuval-Ariel self-assigned this Nov 28, 2022
@Yuval-Ariel Yuval-Ariel added the bug Something isn't working label Nov 28, 2022
Yuval-Ariel added a commit that referenced this issue Nov 28, 2022
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
Yuval-Ariel added a commit that referenced this issue Nov 28, 2022
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
Yuval-Ariel added a commit that referenced this issue Dec 1, 2022
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
Yuval-Ariel added a commit that referenced this issue Apr 30, 2023
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
Yuval-Ariel added a commit that referenced this issue May 4, 2023
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
udi-speedb pushed a commit that referenced this issue Nov 15, 2023
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
while we're at it, also, remove the need to add an exit(1) after ErrorExit
to stop compiler complaining about :
error: control reaches end of non-void function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant