Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db_bench: Recreate only dbs that are in actual use in a group of benchmarks #290

Closed
udi-speedb opened this issue Dec 7, 2022 · 6 comments · Fixed by #370
Closed

db_bench: Recreate only dbs that are in actual use in a group of benchmarks #290

udi-speedb opened this issue Dec 7, 2022 · 6 comments · Fixed by #370
Assignees
@Yuval-Ariel
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs

Comments

@udi-speedb
Copy link
Contributor

When a benchmark in a group requires a freshdb (e.g., fillXXX benchmarks), all of the DB-s are recreated.
However, a user may now use the -dbs_to_use flag to have the benchmark operate on a subset of the available db-s. It makes sense (and aligns with the way the -dbs_to_use flag behaves) to also only recreate those db-s rather that all of them.
@udi-speedb udi-speedb added enhancement New feature or request good first issue Good for newcomers up-for-grabs labels Dec 7, 2022
@bosmatt bosmatt moved this to 🫴 Up for Grabs in Speedb Roadmap Jan 4, 2023
andy-byers pushed a commit to andy-byers/speedb that referenced this issue Jan 19, 2023
db_bench: fix for issue speedb-io#290
02ed080 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).
@Yuval-Ariel Yuval-Ariel linked a pull request Jan 19, 2023 that will close this issue
db_bench: fix for issue #290 #370
Merged
andy-byers pushed a commit to andy-byers/speedb that referenced this issue Jan 23, 2023
db_bench: fix for issue speedb-io#290
58312c1 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).
andy-byers pushed a commit to andy-byers/speedb that referenced this issue Jan 24, 2023
db_bench: fix for issue speedb-io#290
5678018 
Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.
@udi-speedb udi-speedb mentioned this issue Jan 27, 2023
Merged
andy-byers pushed a commit to andy-byers/speedb that referenced this issue Jan 27, 2023
db_bench: fix for issue (speedb-io#290)
159420d 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).

Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.
@Yuval-Ariel
Copy link
Contributor

@udi-speedb , have you verified this works as expected? normal QA cycle is useless here since the changes are only in db_bench..

@udi-speedb
Copy link
Contributor Author

@Yuval-Ariel yes I have

@Yuval-Ariel Yuval-Ariel moved this from 🫴 Up for Grabs to 🏗️ Working on it in Speedb Roadmap Jan 31, 2023
@Yuval-Ariel
Copy link
Contributor

@erez-speedb , plz test. there should be no difference.

@erez-speedb
Copy link

I prefer to tests this after this #285 is resolved.

@erez-speedb
Copy link

This area is not covered in the existing test because most cases caused hangs.
Can marge.

@udi-speedb
Copy link
Contributor Author

I have assigned to @Yuval-Ariel to merge

Yuval-Ariel pushed a commit that referenced this issue Feb 11, 2023
@andy-byers
db_bench: fix for issue (#290) (#370)
5344acd 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).

Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.

Co-authored-by: andy-byers <andrew.byers@utdallas.edu>
@github-project-automation github-project-automation bot moved this from 🏗️ Working on it to 📖 Need your Opinion! in Speedb Roadmap Feb 11, 2023
@bosmatt bosmatt moved this from 📖 Need your Opinion! to ✅ Shipped in Speedb Roadmap Feb 15, 2023
ayulas pushed a commit that referenced this issue Feb 26, 2023
@andy-byers @ayulas
db_bench: fix for issue (#290) (#370)
b0bf1bf 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).

Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.

Co-authored-by: andy-byers <andrew.byers@utdallas.edu>
Yuval-Ariel pushed a commit that referenced this issue May 1, 2023
@andy-byers @Yuval-Ariel
db_bench: fix for issue (#290) (#370)
86c421f 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).

Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.

Co-authored-by: andy-byers <andrew.byers@utdallas.edu>
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
@andy-byers @Yuval-Ariel
db_bench: fix for issue (#290) (#370)
af39698 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).

Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.

Co-authored-by: andy-byers <andrew.byers@utdallas.edu>
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
@andy-byers @udi-speedb
db_bench: fix for issue (#290) (#370)
6f5ceff 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).

Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.

Co-authored-by: andy-byers <andrew.byers@utdallas.edu>
udi-speedb pushed a commit that referenced this issue Nov 15, 2023
@andy-byers @udi-speedb
db_bench: fix for issue (#290) (#370)
733462d 
Changed db_bench so that when using multiple databases (num_multi_db > 1) we only destroy databases that were used for the current group (databases specified in dbs_to_use).

Added logic in `OpenAllDbs()` to handle the case where the `-optimistic_transaction_db` option is used.

Co-authored-by: andy-byers <andrew.byers@utdallas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yuval-Ariel Yuval-Ariel

Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs
Projects
Speedb Roadmap
Status: ✅ Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

db_bench: fix for issue #290 andy-byers/speedb
3 participants
@Yuval-Ariel @udi-speedb @erez-speedb