Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty Memory: Divide allow_stall into allow_delay and stall #552

Open
Yuval-Ariel opened this issue Jun 11, 2023 · 0 comments
Open

Dirty Memory: Divide allow_stall into allow_delay and stall #552

Yuval-Ariel opened this issue Jun 11, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request memory-management

Comments

@Yuval-Ariel
Copy link
Contributor

Yuval-Ariel commented Jun 11, 2023

in #549 , we've started by adding allow_delays == true to enable the new functionality of #423. That required extending the capabilities of the WBM to support all the combinations of allow_stall and allow_delays which was not prepared for the version so the #549 PR ended up with keeping the functionality in one flag.

Its best to add the new functionality of delaying based on memory usage under a new flag (allow_delays) and restore the previous allow_stall so that the behaviour is unchanged for users who want allow_stall which only does stalls.

in addition, the user expects the WBM to delay writes gradually and probably beyond the point of exceeding the memory capacity of the WBM. So the code needs to continue gradually decreasing the write rate even when the WBMs memory usage is beyond the capacity.

@Yuval-Ariel Yuval-Ariel added enhancement New feature or request memory-management labels Jun 11, 2023
@Yuval-Ariel Yuval-Ariel self-assigned this Jun 11, 2023
@Yuval-Ariel Yuval-Ariel changed the title Dirty Memory: keep increasing delay after exceeding capacity Dirty Memory: Divide allow_stall into allow_delay and stall Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request memory-management
Projects
None yet
Development

No branches or pull requests

1 participant