Dirty Memory: Revert allow_stall naming from allow_delays_and_stalls #549
Conversation
|
@Yuval-Ariel - Since this is not part of the release, please add the continuous gradual delay part we have discussed and I will review when that is done. Thanks |
|
@Yuval-Ariel I have partially reviewed. |
|
@udi-speedb it has to be part of the release since its an integral part of #423 . so #552 will be handled elsewhere. plz review asap |
|
we've agreed that for this PR, the allow_delays_and_stalls will be reverted to allow_stall and will be used solely to control the functionality of delaying writes with the WBM. The separation to two different flags, allow_stall and allow_delay is the best approach so that users will have the most flexibility and the behavior can remain unchanged but will be handled in #552 . |
add allow_delays as an additional flag to the WBM ctor to enable the connection between the WBM and Global WriteController. set allow_delays = true to enable memory limit delays.
and set stop delay to be the last delay step instead of kMinWriteRate
Yuval-Ariel
force-pushed
the
revert_wbm_allow_stalls_name
branch
from
cee25d5 to
86a3d6c
Compare
…549) During #423 , the WriteBufferManager ctor parameter allow_stall was renamed to allow_delays_and_stalls to reflect its new capabilities (delaying in addition to stalling (stopping) writes). This creates confusion and unwanted behavior so this PR reverts this change and the new functionality of #423 is controller via the old WriteBufferManager ctor parameter named allow_stall. This commit also sets back the allow_stall default value to false to avoid changing current expected behavior.
…549) During #423 , the WriteBufferManager ctor parameter allow_stall was renamed to allow_delays_and_stalls to reflect its new capabilities (delaying in addition to stalling (stopping) writes). This creates confusion and unwanted behavior so this PR reverts this change and the new functionality of #423 is controller via the old WriteBufferManager ctor parameter named allow_stall. This commit also sets back the allow_stall default value to false to avoid changing current expected behavior.
During #423 , the WriteBufferManager ctor parameter allow_stall was renamed to allow_delays_and_stalls to reflect its new capabilities (delaying in addition to stalling (stopping) writes). This creates confusion and unwanted behavior so this PR reverts this change and the new functionality of #423 is controller via the old WriteBufferManager ctor parameter named allow_stall.
this PR also sets back the allow_stall default value to false to avoid changing current expected behavior.