Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build related fixes from Speedb #7

Closed
isaac-io opened this issue Jun 12, 2022 · 0 comments · Fixed by #8
Closed

Add build related fixes from Speedb #7

isaac-io opened this issue Jun 12, 2022 · 0 comments · Fixed by #8
Assignees
@Yuval-Ariel
Labels
bug Something isn't working

Comments

@isaac-io
Copy link
Contributor

isaac-io commented Jun 12, 2022 •
edited
Loading

Add build fixes from Speedb into OSS

Expected behavior

The code compiles.

Actual behavior

The code breaks the build.

Steps to reproduce the behavior

Compile with GCC on CentOS 7.9, with GCC 12, and with Clang 13.
@isaac-io isaac-io mentioned this issue Jun 12, 2022
Closed
@isaac-io isaac-io linked a pull request Jun 12, 2022 that will close this issue
#7: Add build related fixes from speedb #8
Merged
@isaac-io isaac-io mentioned this issue Jun 12, 2022
Merged
@isaac-io isaac-io added the bug Something isn't working label Jun 12, 2022
@assaf-speedb assaf-speedb mentioned this issue Jul 12, 2022
Closed
This was referenced Jul 14, 2022
Closed
Merged
isaac-io added a commit that referenced this issue Jul 14, 2022
@isaac-io
mutable_db_options: fix a Clang 14 build error (#57)
549c7c0 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
@isaac-io isaac-io mentioned this issue Jul 14, 2022
Closed
isaac-io added a commit that referenced this issue Jul 18, 2022
@isaac-io
mutable_db_options: fix a Clang 14 build error (#57)
d78228d 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
@isaac-io isaac-io mentioned this issue Jul 20, 2022
Closed
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
mutable_db_options: fix a Clang 14 build error (#57)
2358133 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
@udi-speedb udi-speedb mentioned this issue Nov 10, 2022
Closed
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@isaac-io @Yuval-Ariel
mutable_db_options: fix a Clang 14 build error (#57)
b57104d 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
mutable_db_options: fix a Clang 14 build error (#57)
4a70aa7 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
@udi-speedb udi-speedb mentioned this issue Dec 7, 2022
Open
@erez-speedb erez-speedb mentioned this issue Dec 20, 2022
Closed
@Yuval-Ariel Yuval-Ariel mentioned this issue Jan 17, 2023
Open
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
mutable_db_options: fix a Clang 14 build error (#57)
5461017 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
@ayulas ayulas mentioned this issue Aug 16, 2023
Closed
udi-speedb pushed a commit that referenced this issue Oct 31, 2023
@isaac-io @udi-speedb
mutable_db_options: fix a Clang 14 build error (#57)
57fa990 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
udi-speedb pushed a commit that referenced this issue Dec 1, 2023
@isaac-io @udi-speedb
mutable_db_options: fix a Clang 14 build error (#57)
a5ee529 
Clang 14 fails to compile with the following error:

```
options/db_options.h:120:21: error: definition of implicit copy constructor for 'MutableDBOptions' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  MutableDBOptions& operator=(const MutableDBOptions&) = default;
                    ^
db/compaction/compaction_job.cc:439:7: note: in implicit copy constructor for 'rocksdb::MutableDBOptions' first required here
      mutable_db_options_copy_(mutable_db_options),
      ^
```

This is caused by the introduction of an assignment operator in #7 due to
a diagnostic emitted by Clang 13 which isn't emitted by Clang 14, so this
was probably a compiler bug, and we just need to remove the assignment
operator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yuval-Ariel Yuval-Ariel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#7: Add build related fixes from speedb speedb-io/speedb
Build related fixes Yuval-Ariel/speedb
2 participants
@isaac-io @Yuval-Ariel