Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add construction of filter policy for plugins in tools #71

Closed
isaac-io opened this issue Jul 26, 2022 · 0 comments · Fixed by #83
Closed

Add construction of filter policy for plugins in tools #71

isaac-io opened this issue Jul 26, 2022 · 0 comments · Fixed by #83
Assignees
@mrambacher @assaf-speedb
Labels
enhancement New feature or request Upstreamable can be upstreamed to RocksDB
Milestone
v2.1.0

Comments

@isaac-io
Copy link
Contributor

While RocksDB supports a plugin infrastructure, it's not used everywhere, and db_bench, db_stress, and related tools don't allow constructing a custom filter policy from a plugin. This prevents effective testing of filter policies that come from plugins, so we need to add the ability to provide a filter policy URI to the tools.
@isaac-io isaac-io added the enhancement New feature or request label Jul 26, 2022
@mrambacher mrambacher mentioned this issue Jul 28, 2022
Merged
@isaac-io isaac-io added the Upstreamable can be upstreamed to RocksDB label Aug 30, 2022
@isaac-io isaac-io mentioned this issue Sep 12, 2022
Closed
@isaac-io isaac-io added this to the v2.1.0 milestone Sep 21, 2022
isaac-io pushed a commit that referenced this issue Oct 2, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
13b992a
udi-speedb pushed a commit that referenced this issue Oct 3, 2022
@mrambacher @udi-speedb
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
ce83b05
isaac-io added a commit that referenced this issue Oct 3, 2022
@isaac-io
tools: Append bloom_bits to filter_uri as an argument if specified (#71)
2285501
isaac-io pushed a commit that referenced this issue Oct 6, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
0f8f57f
isaac-io pushed a commit that referenced this issue Oct 20, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
9030f67
isaac-io pushed a commit that referenced this issue Oct 20, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
f8e2e97
isaac-io pushed a commit that referenced this issue Oct 20, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
b73f9ba
isaac-io pushed a commit that referenced this issue Oct 24, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
7566679
isaac-io pushed a commit that referenced this issue Oct 24, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
36caea6
isaac-io pushed a commit that referenced this issue Oct 26, 2022
@mrambacher @isaac-io
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
e728962
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@mrambacher @Yuval-Ariel
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
c5c3ff3
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@mrambacher @Yuval-Ariel
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
9ae2752
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@mrambacher @Yuval-Ariel
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
adc9e5b
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
@mrambacher @Yuval-Ariel
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
0586cb8
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
@mrambacher @udi-speedb
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
a15912e
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
@mrambacher @udi-speedb
tools: Make FilterPolicy settable via URI/CreateFromString (#71)
5d8941f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrambacher mrambacher

@assaf-speedb assaf-speedb

Labels
enhancement New feature or request Upstreamable can be upstreamed to RocksDB
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

71 filter policy uri speedb-io/speedb
3 participants
@mrambacher @isaac-io @assaf-speedb