Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add the Speedb plugin to the build by default #87

Closed
isaac-io opened this issue Jul 31, 2022 · 0 comments · Fixed by #88
Closed

build: add the Speedb plugin to the build by default #87

isaac-io opened this issue Jul 31, 2022 · 0 comments · Fixed by #88
Assignees
@isaac-io
Labels
enhancement New feature or request

Comments

@isaac-io
Copy link
Contributor

Currently users have to opt into building the Speedb plugin in order to gain access to the new memtable (and other features in the future). Change the Makefile and the CMake configuration to add it if it hasn't been specified.
@isaac-io isaac-io added the enhancement New feature or request label Jul 31, 2022
@isaac-io isaac-io self-assigned this Jul 31, 2022
isaac-io added a commit that referenced this issue Jul 31, 2022
@isaac-io
build: always add the Speedb plugin to the build (#87)
f4c576c 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
@isaac-io isaac-io linked a pull request Jul 31, 2022 that will close this issue
build: always add the Speedb plugin to the build (#87) #88
Merged
isaac-io added a commit that referenced this issue Jul 31, 2022
@isaac-io
build: always add the Speedb plugin to the build (#87)
5a2dd3f 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
build: always add the Speedb plugin to the build (#87)
ef1a0f3 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
build: always add the Speedb plugin to the build (#87)
6c9d79a 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
build: always add the Speedb plugin to the build (#87)
fd763a7 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
build: always add the Speedb plugin to the build (#87)
10650e1 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
isaac-io added a commit that referenced this issue Oct 19, 2022
@isaac-io
build: always add the Speedb plugin to the build (#87)
bc2c629 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@isaac-io @Yuval-Ariel
build: always add the Speedb plugin to the build (#87)
5053c11 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
build: always add the Speedb plugin to the build (#87)
bdc04c2 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
build: always add the Speedb plugin to the build (#87)
5bbd306 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
udi-speedb pushed a commit that referenced this issue Oct 31, 2023
@isaac-io @udi-speedb
build: always add the Speedb plugin to the build (#87)
7ce9144 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
udi-speedb pushed a commit that referenced this issue Dec 1, 2023
@isaac-io @udi-speedb
build: always add the Speedb plugin to the build (#87)
dde11bd 
This allows us to make sure that our additions are included
in the build even if the user forgot to set `ROCKSDB_PLUGINS`
explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaac-io isaac-io

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: always add the Speedb plugin to the build (#87) speedb-io/speedb
1 participant
@isaac-io