Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spdb_memtable: build fails due to an unused argumet #91

Closed
isaac-io opened this issue Jul 31, 2022 · 1 comment · Fixed by #92
Closed

spdb_memtable: build fails due to an unused argumet #91

isaac-io opened this issue Jul 31, 2022 · 1 comment · Fixed by #92
Assignees
@isaac-io
Labels
bug Something isn't working

Comments

@isaac-io
Copy link
Contributor

Due to a last minute change before merging #30, the logger argument to CreateMemTableRep() is now unused. In some configurations where unused variables are treated as errors, this breaks the compilation.

This currently breaks the QA unit test runs.

To Reproduce

Compile main with -Werror and -Wunused-parameter. It fails with:

plugin/speedb/memtable/hash_spd_rep.cc: In member function 'virtual rocksdb::MemTableRep* rocksdb::HashSpdRepFactory::CreateMemTableRep(const rocksdb::MemTableRep::KeyComparator&, rocksdb::Allocator*, const rocksdb::SliceTransform*, rocksdb::Logger*)':
plugin/speedb/memtable/hash_spd_rep.cc:984:50: error: unused parameter 'logger' [-Werror=unused-parameter]
     const SliceTransform* /*transform*/, Logger* logger) {

Expected behavior

Compilation succeeds.

System (please complete the following information)

  • OS: Ubuntu 20.04
  • Compiler: GCC

Additional context

N/A
@isaac-io isaac-io added the bug Something isn't working label Jul 31, 2022
@isaac-io isaac-io self-assigned this Jul 31, 2022
@isaac-io
Copy link
Contributor Author

Reported by @assaf-speedb

isaac-io added a commit that referenced this issue Jul 31, 2022
@isaac-io
spdb_memtable: fix an unused parameter issue (#91)
0e8c311 
A last minute change before merging #30 breaks builds that configure
`-Werror=unused-parameter` (this is the default for some GCC versions
with the `-Wextra` configuration).

Fix it by not declaring the `logger` argument to the `CreateMemTableRep()`
function.
@isaac-io isaac-io linked a pull request Jul 31, 2022 that will close this issue
spdb_memtable: fix an unused parameter issue (#91) #92
Merged
isaac-io added a commit that referenced this issue Jul 31, 2022
@isaac-io
spdb_memtable: fix an unused parameter issue (#91)
5d78425 
A last minute change before merging #30 breaks builds that configure
`-Werror=unused-parameter` (this is the default for some GCC versions
with the `-Wextra` configuration).

Fix it by not declaring the `logger` argument to the `CreateMemTableRep()`
function.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@isaac-io @Yuval-Ariel
spdb_memtable: fix an unused parameter issue (#91)
48b2fd8 
A last minute change before merging #30 breaks builds that configure
`-Werror=unused-parameter` (this is the default for some GCC versions
with the `-Wextra` configuration).

Fix it by not declaring the `logger` argument to the `CreateMemTableRep()`
function.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
spdb_memtable: fix an unused parameter issue (#91)
783b0b6 
A last minute change before merging #30 breaks builds that configure
`-Werror=unused-parameter` (this is the default for some GCC versions
with the `-Wextra` configuration).

Fix it by not declaring the `logger` argument to the `CreateMemTableRep()`
function.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
spdb_memtable: fix an unused parameter issue (#91)
892bf2d 
A last minute change before merging #30 breaks builds that configure
`-Werror=unused-parameter` (this is the default for some GCC versions
with the `-Wextra` configuration).

Fix it by not declaring the `logger` argument to the `CreateMemTableRep()`
function.
udi-speedb pushed a commit that referenced this issue Oct 31, 2023
@isaac-io @udi-speedb
spdb_memtable: fix an unused parameter issue (#91)
00d3796 
A last minute change before merging #30 breaks builds that configure
`-Werror=unused-parameter` (this is the default for some GCC versions
with the `-Wextra` configuration).

Fix it by not declaring the `logger` argument to the `CreateMemTableRep()`
function.
udi-speedb pushed a commit that referenced this issue Dec 1, 2023
@isaac-io @udi-speedb
spdb_memtable: fix an unused parameter issue (#91)
dd5e6b9 
A last minute change before merging #30 breaks builds that configure
`-Werror=unused-parameter` (this is the default for some GCC versions
with the `-Wextra` configuration).

Fix it by not declaring the `logger` argument to the `CreateMemTableRep()`
function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaac-io isaac-io

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spdb_memtable: fix an unused parameter issue (#91) speedb-io/speedb
1 participant
@isaac-io