#9: port db stress changes from speedb to the oss version #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuval-Ariel
approved these changes
Jun 14, 2022
isaac-io
force-pushed
the
9-port-db_stress-changes-from-speedb-to-the-oss-version
branch
from
979ef96 to
7450e67
Compare
Yuval-Ariel
force-pushed
the
9-port-db_stress-changes-from-speedb-to-the-oss-version
branch
3 times, most recently
from
32ee3d0 to
bb4174a
Compare
VodOleg
reviewed
Jun 26, 2022
VodOleg
reviewed
Jun 26, 2022
Yuval-Ariel
force-pushed
the
9-port-db_stress-changes-from-speedb-to-the-oss-version
branch
from
bb4174a to
8c85231
Compare
This helps debug things by correlating with other events in the system, which we are unable to connect currently due to lack of information on which process failed and when.
SPDB-225 added copying of the database during tests in order to preserve the state of the database, but after a successful run there's no reason to keep these copies around, so remove them.
The command is printed anyway by execute_cmd(), so there's no need to print it in whitebox_crash_main() as well.
The current code is broken, because it effectively sets bool() as the conversion function for boolean arguments, but bool() returns True for every non-empty string, so that doesn't work. Add a converter function to parse boolean value and set it as the type for argparse in case the argument is of type bool.
…snapshot In batched snapshot mode each key is duplicated 10 times and prefixed with an ASCII digit in the range 0-9. However, the snapshot verification code assumed that each key is present exactly as generated and exactly once, so the calculated key index was bogus and lead to an invalid memory access. Fix it by making the snapshot verification code aware of the batched mode and apply the key conversion and verification accordingly. While at it, clean up the way the verification bit vector is allocated.
db_stress does not support running successive runs with different values of test_batches_snapshots.
in addition, add randomize_operation_type_percentages
This changes the way the stress test parameters are generated in order to increase the coverage of the test and check for more edge cases. Additionally, this change adds the option to run whitebox tests with kill points disabled for testing functionality without crash recovery. SPDB-390: crash_test: fix bool flags SPDB-388: crash_test: disallow zero key dist val zero vals in key_len_percent_dist are incompatible with db_stress_common.h::GetIntVal
…ncy is on running with both options, the stress test chosen is cf_consistency_stress which does not use '0' - '9' as prefix for keys as in batched_ops_stress. when doing compare_full_db_state_snapshot, the code expects each key to have the prefix since test_batches_snapshots==true. there is no point when both flags are on since each is run as a different stress test.
user can now switch between kDataBlockBinarySearch and kDataBlockBinaryAndHash
also fix handling of customopspercent which atm is only applicable to test_multiops_txn by making sure its 0 in all the other configs.
Yuval-Ariel
force-pushed
the
9-port-db_stress-changes-from-speedb-to-the-oss-version
branch
from
8c85231 to
7aca1b2
Compare
VodOleg
approved these changes
Jun 27, 2022
|
passed QA |
Yuval-Ariel
deleted the
9-port-db_stress-changes-from-speedb-to-the-oss-version
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9