ci: add a /var/tmp volume to the QA tests to fix tests failing (#107) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-io
force-pushed
the
107-ci-unit-tests-fail-due-to-missing-fs_ios_getversion-and-possibly-overlay2-bug
branch
2 times, most recently
from
a01480b to
672562f
Compare
maxb-io
approved these changes
Aug 3, 2022
isaac-io
force-pushed
the
107-ci-unit-tests-fail-due-to-missing-fs_ios_getversion-and-possibly-overlay2-bug
branch
6 times, most recently
from
b30d5f9 to
173b098
Compare
The tests that break are `env_test` and `db_test`. `env_test` fails due to trying to use `FS_IOC_GETVERSION` on an overlayfs, which doesn't support it. We need to use a host filesystem for this because only certain filesytsems support this ioctl. For this we add a host bind volume to /var/tmp which is what the code tries to use. `db_test` fails for an unknown reason and only in buffered I/O mode, which might indicate a bug in overlayfs. This is caused by a setting of the `TMPD` environment variable to the overlayfs mount. Add a mount to the host's /tmp directory and set `TMPD` to it instead (we can't use the default of /dev/shm because there's not enough memory available on the runner machines). While at it, clean up the workflow definition a bit.
isaac-io
force-pushed
the
107-ci-unit-tests-fail-due-to-missing-fs_ios_getversion-and-possibly-overlay2-bug
branch
from
173b098 to
f760381
Compare
isaac-io
deleted the
107-ci-unit-tests-fail-due-to-missing-fs_ios_getversion-and-possibly-overlay2-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests that break are
env_testanddb_test.env_testfails due to trying to useFS_IOC_GETVERSIONon an overlayfs,which doesn't support it. We need to use a host filesystem for this because
only certain filesytsems support this ioctl. For this we add a host bind
volume to /var/tmp which is what the code tries to use.
db_testfails for an unknown reason and only in buffered I/O mode, whichmight indicate a bug in overlayfs. This is caused by a setting of the
TMPDenvironment variable to the overlayfs mount. Add a mount to the host's /tmp
directory and set
TMPDto it instead (we can't use the default of /dev/shmbecause there's not enough memory available on the runner machines).
While at it, clean up the workflow definition a bit.