Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new release line network hotfix #109

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Conversation

nathan-bo
Copy link
Contributor

No description provided.

@nathan-bo nathan-bo requested review from isaac-io and maxb-io August 4, 2022 07:12
Comment on lines 21 to 22
apk update && apk add git
echo "nameserver 8.8.8.8" > /etc/resolv.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the other way around? apk update and apk add already access the network.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the order

@isaac-io isaac-io merged commit 4866126 into main Aug 4, 2022
@isaac-io isaac-io deleted the devops-ci/new_release_network_hotfix branch August 4, 2022 07:41
Yuval-Ariel pushed a commit that referenced this pull request Nov 23, 2022
* changed order of network hofix
Yuval-Ariel pushed a commit that referenced this pull request Nov 25, 2022
* changed order of network hofix
Yuval-Ariel pushed a commit that referenced this pull request Apr 30, 2023
Devops ci/add build tools (#104)

new release line network hotfix (#109)
udi-speedb pushed a commit that referenced this pull request Oct 31, 2023
Devops ci/add build tools (#104)

new release line network hotfix (#109)
udi-speedb pushed a commit that referenced this pull request Dec 1, 2023
Devops ci/add build tools (#104)

new release line network hotfix (#109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants