Devops ci/move fuzz to reusable workflow #133
Conversation
| chmod +x prepfuz.sh | ||
| bash -xv prepfuz.sh |
There was a problem hiding this comment.
Why not simply run the commands instead of outputting them to a file and executing it?
There was a problem hiding this comment.
This is the way it was ran in gitlab ci, I think @maxb-io explained it to me but I can't really remember
.github/workflows/test_fuzz.yml
Outdated
| - name: Copy ${{ matrix.name }} logs to S3 | ||
| run: | | ||
| aws s3 cp $GITHUB_WORKSPACE/out/${{ matrix.name }}.log-$GITHUB_SHA s3://spdb-github-ci/ | ||
| aws s3 cp $GITHUB_WORKSPACE/out/${{ matrix.name }}.log s3://spdb-github-ci/$GITHUB_SHA-${{ matrix.name }}.log |
There was a problem hiding this comment.
What's the use of uploading the logs to S3 after the fuzzer has already succeeded? I case of failure this job will not be executed anyway (because the previous job would fail), and in a successful run we have no use for the logs.
There was a problem hiding this comment.
I was told we want to save the logs, is this not correct? I can remove it if there's no use
There was a problem hiding this comment.
The job later removes them, so they are not saved anyway. What we need is a way to store the logs on failure, not on success.
There was a problem hiding this comment.
the clean is only for testing, so that it will automatically clean itself instead of manually doing it. I'll change it to save only when the job fails
There was a problem hiding this comment.
made the change, let me know if you want it different
isaac-io
force-pushed
the
devops-ci/move_fuzz_to_reusable_workflow
branch
from
8b443c2 to
2a42fb1
Compare
.github/workflows/test_fuzz.yml
Outdated
|
|
||
| - name: fuzzersum | ||
| - name: Copy ${{ matrix.name }} logs to S3 due to failure | ||
| if: steps.${{ matrix.name }}.outcome != 'success' |
There was a problem hiding this comment.
This will run on cancellation, which we don't really want. You should probably only run this on failure.
There was a problem hiding this comment.
changed it to run explicitly if the outcome is 'failure'
.github/workflows/ci_pipeline.yml
Outdated
| - name: clear s3 bucket | ||
| run: | | ||
| aws s3 rm s3://spdb-github-ci/ --recursive --include "*" | ||
| uses: speedb-io/speedb/.github/workflows/test_fuzz.yml@main |
There was a problem hiding this comment.
Let's use the local repository syntax without pinning to main.
Move the definition of the fuzz testing jobs to a separate workflow so that it could be reused by workflows other than the main CI one.
Move the definition of the fuzz testing jobs to a separate workflow so that it could be reused by workflows other than the main CI one.
Move the definition of the fuzz testing jobs to a separate workflow so that it could be reused by workflows other than the main CI one.
Move the definition of the fuzz testing jobs to a separate workflow so that it could be reused by workflows other than the main CI one.
Move the definition of the fuzz testing jobs to a separate workflow so that it could be reused by workflows other than the main CI one.
No description provided.