Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace usages of egrep with grep -E (#166) #167

Conversation

isaac-io
Copy link
Contributor

egrep and fgrep have been deprecated for a long time in GNU grep, and as of release 3.8 using them prints a warning message, as stated in the 3.8 release notes:

The egrep and fgrep commands, which have been deprecated since
release 2.5.3 (2007), now warn that they are obsolescent and should
be replaced by grep -E and grep -F.

egrep is used during the build to query the version, and with the warning that's now being printed this adds unneeded noise to the output of the build. Replace the usage of egrep with grep -E to get rid of the warning.

@isaac-io isaac-io self-assigned this Sep 16, 2022
@isaac-io isaac-io linked an issue Sep 16, 2022 that may be closed by this pull request
egrep and fgrep have been deprecated for a long time in GNU grep, and as
of release 3.8 using them prints a warning message, as stated in the 3.8
release notes:

> The egrep and fgrep commands, which have been deprecated since
> release 2.5.3 (2007), now warn that they are obsolescent and should
> be replaced by grep -E and grep -F.

egrep is used during the build to query the version, and with the warning
that's now being printed this adds unneeded noise to the output of the
build. Replace the usage of egrep with grep -E to get rid of the warning.
@isaac-io isaac-io force-pushed the 166-build-output-is-cluttered-with-warnings-about-egrep-being-obsolete branch from 3769b0e to 1833f1f Compare September 16, 2022 07:59
@isaac-io isaac-io added the Upstreamable can be upstreamed to RocksDB label Sep 19, 2022
@isaac-io isaac-io merged commit 3c73576 into main Sep 21, 2022
@isaac-io isaac-io deleted the 166-build-output-is-cluttered-with-warnings-about-egrep-being-obsolete branch September 29, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstreamable can be upstreamed to RocksDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build output is cluttered with warnings about egrep being obsolete
2 participants